[https://nvbugs/5543035][chore] Test on main #8906
Conversation
Signed-off-by: Wangshanshan <[email protected]>
dominicshanshan
changed the title
dominicshanshan
changed the title
📝 WalkthroughWalkthroughTwo test configuration lines are uncommented in the RTX Pro 6000 test database file, enabling a previously disabled test case for Qwen 3.8B auto dtype functionality across two locations. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
tests/integration/test_lists/test-db/l0_rtx_pro_6000.yml(1 hunks)
🧰 Additional context used
🧠 Learnings (4)
📚 Learning: 2025-09-09T09:40:45.658Z
Learnt from: fredricz-20070104
Repo: NVIDIA/TensorRT-LLM PR: 7645
File: tests/integration/test_lists/qa/llm_function_core.txt:648-648
Timestamp: 2025-09-09T09:40:45.658Z
Learning: In TensorRT-LLM test lists, it's common and intentional for the same test to appear in multiple test list files when they serve different purposes (e.g., llm_function_core.txt for comprehensive core functionality testing and llm_function_core_sanity.txt for quick sanity checks). This duplication allows tests to be run in different testing contexts.
Applied to files:
tests/integration/test_lists/test-db/l0_rtx_pro_6000.yml
📚 Learning: 2025-09-17T02:48:52.732Z
Learnt from: tongyuantongyu
Repo: NVIDIA/TensorRT-LLM PR: 7781
File: tests/integration/test_lists/waives.txt:313-313
Timestamp: 2025-09-17T02:48:52.732Z
Learning: In TensorRT-LLM, `tests/integration/test_lists/waives.txt` is specifically for waiving/skipping tests, while other test list files like those in `test-db/` and `qa/` directories are for different test execution contexts (pre-merge, post-merge, QA tests). The same test appearing in both waives.txt and execution list files is intentional - the test is part of test suites but will be skipped due to the waiver.
Applied to files:
tests/integration/test_lists/test-db/l0_rtx_pro_6000.yml
📚 Learning: 2025-08-26T09:49:04.956Z
Learnt from: pengbowang-nv
Repo: NVIDIA/TensorRT-LLM PR: 7192
File: tests/integration/test_lists/test-db/l0_dgx_b200.yml:56-72
Timestamp: 2025-08-26T09:49:04.956Z
Learning: In TensorRT-LLM test configuration files, the test scheduling system handles wildcard matching with special rules that prevent duplicate test execution even when the same tests appear in multiple yaml files with overlapping GPU wildcards (e.g., "*b200*" and "*gb200*").
Applied to files:
tests/integration/test_lists/test-db/l0_rtx_pro_6000.yml
📚 Learning: 2025-07-28T17:06:08.621Z
Learnt from: moraxu
Repo: NVIDIA/TensorRT-LLM PR: 6303
File: tests/integration/test_lists/qa/examples_test_list.txt:494-494
Timestamp: 2025-07-28T17:06:08.621Z
Learning: In TensorRT-LLM testing, it's common to have both CLI flow tests (test_cli_flow.py) and PyTorch API tests (test_llm_api_pytorch.py) for the same model. These serve different purposes: CLI flow tests validate the traditional command-line workflow, while PyTorch API tests validate the newer LLM API backend. Both are legitimate and should coexist.
Applied to files:
tests/integration/test_lists/test-db/l0_rtx_pro_6000.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Check PR Checklist Resolution
- GitHub Check: Pre-commit Check
| # - accuracy/test_disaggregated_serving.py::TestQwen3_8B::test_auto_dtype[False] # hopper only | ||
| # - accuracy/test_disaggregated_serving.py::TestQwen3_8B::test_auto_dtype[True] | ||
| - accuracy/test_disaggregated_serving.py::TestQwen3_8B::test_auto_dtype[True] |
There was a problem hiding this comment.
Add context explaining why the flaky test is being re-enabled.
The uncommented test at line 99 lacks an inline comment explaining the fix or rationale, unlike nearby entries (e.g., line 98's "# hopper only" or lines 96–97's GDRCopy notes). This makes it unclear whether the underlying flaky condition has been resolved or if this is experimental re-enablement. Add a comment clarifying the fix strategy.
Suggested fix:
- - accuracy/test_disaggregated_serving.py::TestQwen3_8B::test_auto_dtype[True]
+ - accuracy/test_disaggregated_serving.py::TestQwen3_8B::test_auto_dtype[True] # https://nvbugs/5543035 - flaky issue resolved📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| # - accuracy/test_disaggregated_serving.py::TestQwen3_8B::test_auto_dtype[False] # hopper only | |
| # - accuracy/test_disaggregated_serving.py::TestQwen3_8B::test_auto_dtype[True] | |
| - accuracy/test_disaggregated_serving.py::TestQwen3_8B::test_auto_dtype[True] | |
| # - accuracy/test_disaggregated_serving.py::TestQwen3_8B::test_auto_dtype[False] # hopper only | |
| - accuracy/test_disaggregated_serving.py::TestQwen3_8B::test_auto_dtype[True] # https://nvbugs/5543035 - flaky issue resolved |
🤖 Prompt for AI Agents
In tests/integration/test_lists/test-db/l0_rtx_pro_6000.yml around lines 98 to
99, the uncommented test entry at line 99 re-enables a previously flaky test but
lacks an explanatory inline comment; add a short inline comment after that line
describing why the test was re-enabled (e.g., what root cause was fixed, what
environment or config change stabilizes it, and reference to the related
issue/PR or commit) so future readers know this is intentional and not
experimental.
| # - accuracy/test_llm_api_pytorch.py::TestDeepSeekV3Lite::test_bfloat16_4gpus_online_eplb[mtp_nextn=2] # Verify GDRCopy availability on Blossom pods | ||
| # - accuracy/test_disaggregated_serving.py::TestQwen3_8B::test_auto_dtype[False] # hopper only | ||
| # - accuracy/test_disaggregated_serving.py::TestQwen3_8B::test_auto_dtype[True] | ||
| - accuracy/test_disaggregated_serving.py::TestQwen3_8B::test_auto_dtype[True] |
There was a problem hiding this comment.
🧩 Analysis chain
Verify the scope of changes matches the AI summary.
The AI summary claims the test is uncommented "across two locations," but the annotated code shows only one marked change at line 99. Confirm whether this is the only modification or if another location was changed outside the provided context.
🏁 Script executed:
#!/bin/bash
# Description: Verify all uncommented occurrences of TestQwen3_8B::test_auto_dtype[True] in l0_rtx_pro_6000.yml
# Find all non-commented occurrences of the test
rg -n 'TestQwen3_8B::test_auto_dtype\[True\]' tests/integration/test_lists/test-db/l0_rtx_pro_6000.yml | grep -v '^\s*#'
# Also show surrounding context to confirm uncommenting
rg -B2 -A2 'TestQwen3_8B::test_auto_dtype\[True\]' tests/integration/test_lists/test-db/l0_rtx_pro_6000.ymlLength of output: 624
🏁 Script executed:
#!/bin/bash
# Get precise line numbers and full context for all occurrences
cat -n tests/integration/test_lists/test-db/l0_rtx_pro_6000.yml | grep -A5 -B5 'TestQwen3_8B::test_auto_dtype\[True\]'Length of output: 88
---
🏁 Script executed:
```shell
#!/bin/bash
# Get precise line numbers and full context for all occurrences of the test
sed -n '90,110p' tests/integration/test_lists/test-db/l0_rtx_pro_6000.yml | cat -n
Length of output: 3083
🏁 Script executed:
#!/bin/bash
# Search entire file for all uncommented occurrences of the test
echo "=== All lines matching test_auto_dtype[True] (excluding comments) ==="
rg -n 'TestQwen3_8B::test_auto_dtype\[True\]' tests/integration/test_lists/test-db/l0_rtx_pro_6000.yml | grep -v '^\s*#'
echo ""
echo "=== Total count of uncommented occurrences ==="
rg -n 'TestQwen3_8B::test_auto_dtype\[True\]' tests/integration/test_lists/test-db/l0_rtx_pro_6000.yml | grep -v '^\s*#' | wc -lLength of output: 202
Remove incorrect AI summary claim and add required explanation for the uncommented test.
Verification confirms the AI summary is incorrect: there is only ONE uncommented instance at line 99, not "across two locations." However, this uncommented test lacks explanation or context. Related code (line 98) includes a helpful inline comment ("# hopper only"), but the newly uncommented test has no annotation explaining why it's being re-enabled in response to NVBUG 5543035. Add an inline comment clarifying the reason for uncommenting this test case.
🤖 Prompt for AI Agents
In tests/integration/test_lists/test-db/l0_rtx_pro_6000.yml around line 99, the
review incorrectly stated two uncommented instances but there is only ONE
uncommented test at line 99 and it lacks context; update the file by adding an
inline comment immediately above or beside the uncommented test line that
explains why this specific test was re-enabled (eg. reference NVBUG-5543035 and
any scope/conditions like "hopper only"), and remove or correct any text
elsewhere claiming multiple uncommented locations so the file and comment
accurately reflect the single re-enabled test and its rationale.
|
/bot run --stage-list "GB200-4_GPUs-PyTorch-1" |
|
PR_Github #23485 [ run ] triggered by Bot. Commit: |
|
PR_Github #23485 [ run ] completed with state |
2 participants
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.